drm/i915: Fix pipeDMC and ATS fault handling
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 24 Feb 2025 17:30:17 +0000 (19:30 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 26 Feb 2025 15:57:03 +0000 (17:57 +0200)
The fault handler is supposed to return true when it
handles the fault. The pipeDMC and ATS handlers are
returning false instead which results in the
"unreported faults" WARN triggering when it shouldn't.

Fixes: f13011a79999 ("drm/i915: Pimp display fault reporting")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250224173017.29500-1-ville.syrjala@linux.intel.com
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
drivers/gpu/drm/i915/display/intel_display_irq.c

index 99fb7fc7be39444f8a6440a4fd7546425745231c..aa23bb81780534d00e9ffd2de506119747445793 100644 (file)
@@ -1101,7 +1101,7 @@ static bool handle_plane_ats_fault(struct intel_crtc *crtc, enum plane_id plane_
                            "[CRTC:%d:%s] PLANE ATS fault\n",
                            crtc->base.base.id, crtc->base.name);
 
-       return false;
+       return true;
 }
 
 static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plane_id)
@@ -1112,7 +1112,7 @@ static bool handle_pipedmc_ats_fault(struct intel_crtc *crtc, enum plane_id plan
                            "[CRTC:%d:%s] PIPEDMC ATS fault\n",
                            crtc->base.base.id, crtc->base.name);
 
-       return false;
+       return true;
 }
 
 static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id)
@@ -1123,7 +1123,7 @@ static bool handle_pipedmc_fault(struct intel_crtc *crtc, enum plane_id plane_id
                            "[CRTC:%d:%s] PIPEDMC fault\n",
                            crtc->base.base.id, crtc->base.name);
 
-       return false;
+       return true;
 }
 
 static const struct pipe_fault_handler mtl_pipe_fault_handlers[] = {