nfp: Use IRQF_NO_AUTOEN flag in request_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Wed, 11 Sep 2024 09:44:45 +0000 (17:44 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Sep 2024 03:35:04 +0000 (20:35 -0700)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Reviewed-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20240911094445.1922476-4-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c

index 182ba0a8b095bc2294663dc9d77f7942f0367fb7..6e0929af0f725b2b3855c69bbe894e6626c566b3 100644 (file)
@@ -821,14 +821,13 @@ nfp_net_prepare_vector(struct nfp_net *nn, struct nfp_net_r_vector *r_vec,
 
        snprintf(r_vec->name, sizeof(r_vec->name),
                 "%s-rxtx-%d", nfp_net_name(nn), idx);
-       err = request_irq(r_vec->irq_vector, r_vec->handler, 0, r_vec->name,
-                         r_vec);
+       err = request_irq(r_vec->irq_vector, r_vec->handler, IRQF_NO_AUTOEN,
+                         r_vec->name, r_vec);
        if (err) {
                nfp_net_napi_del(&nn->dp, r_vec);
                nn_err(nn, "Error requesting IRQ %d\n", r_vec->irq_vector);
                return err;
        }
-       disable_irq(r_vec->irq_vector);
 
        irq_set_affinity_hint(r_vec->irq_vector, &r_vec->affinity_mask);