platform/x86: think-lmi: Remove custom kobject sysfs_ops
authorThomas Weißschuh <linux@weissschuh.net>
Tue, 14 Mar 2023 00:07:52 +0000 (00:07 +0000)
committerHans de Goede <hdegoede@redhat.com>
Thu, 16 Mar 2023 14:42:17 +0000 (15:42 +0100)
think-lmi defines its own sysfs_ops that are identical to the standard
kobj_sysfs_ops. Use the standard definitions.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20230314-think-lmi-sysfs_ops-v1-1-9d4f1cf9caec@weissschuh.net
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/think-lmi.c

index c924e9e4a6a5bd67712faa263e5ba36beba0c080..cc66f7cbccf226d0818b3a7b1fb062f3af47675d 100644 (file)
@@ -1047,33 +1047,6 @@ static const struct attribute_group tlmi_attr_group = {
        .attrs = tlmi_attrs,
 };
 
-static ssize_t tlmi_attr_show(struct kobject *kobj, struct attribute *attr,
-                                   char *buf)
-{
-       struct kobj_attribute *kattr;
-
-       kattr = container_of(attr, struct kobj_attribute, attr);
-       if (kattr->show)
-               return kattr->show(kobj, kattr, buf);
-       return -EIO;
-}
-
-static ssize_t tlmi_attr_store(struct kobject *kobj, struct attribute *attr,
-                                    const char *buf, size_t count)
-{
-       struct kobj_attribute *kattr;
-
-       kattr = container_of(attr, struct kobj_attribute, attr);
-       if (kattr->store)
-               return kattr->store(kobj, kattr, buf, count);
-       return -EIO;
-}
-
-static const struct sysfs_ops tlmi_kobj_sysfs_ops = {
-       .show   = tlmi_attr_show,
-       .store  = tlmi_attr_store,
-};
-
 static void tlmi_attr_setting_release(struct kobject *kobj)
 {
        struct tlmi_attr_setting *setting = to_tlmi_attr_setting(kobj);
@@ -1091,12 +1064,12 @@ static void tlmi_pwd_setting_release(struct kobject *kobj)
 
 static const struct kobj_type tlmi_attr_setting_ktype = {
        .release        = &tlmi_attr_setting_release,
-       .sysfs_ops      = &tlmi_kobj_sysfs_ops,
+       .sysfs_ops      = &kobj_sysfs_ops,
 };
 
 static const struct kobj_type tlmi_pwd_setting_ktype = {
        .release        = &tlmi_pwd_setting_release,
-       .sysfs_ops      = &tlmi_kobj_sysfs_ops,
+       .sysfs_ops      = &kobj_sysfs_ops,
 };
 
 static ssize_t pending_reboot_show(struct kobject *kobj, struct kobj_attribute *attr,