cxl: Fix an error message

'rc' is known to be 0 here.
Initialize 'rc' with the expected error code before using it.

While at it, avoid the affectation of 'rc' in a 'if' to make things more
obvious and linux style.

Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards for userspace access")
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/fa2b2c9c72335ab4c3d5e6a33415e7f020b1d51b.1620243401.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c
index bd3bd32333c5c285f692eb63196dcbde35c38b4b..3dbdce96fae0dfb4339aceef17c823ad1536509f 100644 (file)
--- a/drivers/misc/cxl/file.c
+++ b/drivers/misc/cxl/file.c
@@ -569,7 +569,8 @@ static int cxl_add_chardev(struct cxl_afu *afu, dev_t devt, struct cdev *cdev,
        int rc;
 
        cdev_init(cdev, fops);
-       if ((rc = cdev_add(cdev, devt, 1))) {
+       rc = cdev_add(cdev, devt, 1);
+       if (rc) {
                dev_err(&afu->dev, "Unable to add %s chardev: %i\n", desc, rc);
                return rc;
        }
@@ -577,8 +578,8 @@ static int cxl_add_chardev(struct cxl_afu *afu, dev_t devt, struct cdev *cdev,
        dev = device_create(cxl_class, &afu->dev, devt, afu,
                        "afu%i.%i%s", afu->adapter->adapter_num, afu->slice, postfix);
        if (IS_ERR(dev)) {
-               dev_err(&afu->dev, "Unable to create %s chardev in sysfs: %i\n", desc, rc);
                rc = PTR_ERR(dev);
+               dev_err(&afu->dev, "Unable to create %s chardev in sysfs: %i\n", desc, rc);
                goto err;
        }