soc/tegra: flowctrl: Fix error handling
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Tue, 11 Apr 2017 03:40:41 +0000 (05:40 +0200)
committerThierry Reding <treding@nvidia.com>
Tue, 13 Jun 2017 14:47:44 +0000 (16:47 +0200)
It is likely that returning returned by 'devm_ioremap_resource()' is
expected here instead of something related to 'base' which should be a
valid pointer at this point.

Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/flowctrl.c

index 0e345c05fc6529faefe7f991c5f98845e6db07a5..5433cc7a043e147f8e6a0165e09ef4f9ae86ac54 100644 (file)
@@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(tegra_flowctrl_base))
-               return PTR_ERR(base);
+               return PTR_ERR(tegra_flowctrl_base);
 
        iounmap(base);