staging: r8188eu: RxMIMOSignalQuality is set but not used
authorMartin Kaiser <martin@kaiser.cx>
Fri, 18 Feb 2022 09:30:31 +0000 (10:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Feb 2022 17:10:35 +0000 (18:10 +0100)
The RxMIMOSignalQuality array in struct signal_stat is set but
not used. Remove it.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220218093034.854049-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/odm_HWConfig.c
drivers/staging/r8188eu/include/rtw_recv.h

index dcc38b0362800c17dd99c6b900f48c743400480a..8ebcd30508923c582c25372aae3290d43a253313 100644 (file)
@@ -67,9 +67,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
 
        isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
 
-       pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] = -1;
-       pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] = -1;
-
        if (isCCKrate) {
                u8 cck_agc_rpt;
 
@@ -150,8 +147,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
                                        SQ = ((64 - SQ_rpt) * 100) / 44;
                        }
                        pPhyInfo->SignalQuality = SQ;
-                       pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] = SQ;
-                       pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] = -1;
                }
        } else { /* is OFDM rate */
                dm_odm->PhyDbgInfo.NumQryPhyStatusOFDM++;
@@ -203,7 +198,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
                        if (pPktinfo->bPacketMatchBSSID) {
                                if (i == RF_PATH_A) /*  Fill value in RFD, Get the first spatial stream only */
                                        pPhyInfo->SignalQuality = (u8)(EVM & 0xff);
-                               pPhyInfo->RxMIMOSignalQuality[i] = (u8)(EVM & 0xff);
                        }
                }
        }
index 920f33235e0003d5000a10df660f9baa1c401f37..f82a26a675c091d880ca2c0758200403544731de 100644 (file)
@@ -72,7 +72,6 @@ struct signal_stat {
 struct phy_info {
        u8      RxPWDBAll;
        u8      SignalQuality;   /*  in 0-100 index. */
-       u8      RxMIMOSignalQuality[MAX_PATH_NUM_92CS]; /* EVM */
        u8      RxMIMOSignalStrength[MAX_PATH_NUM_92CS];/*  in 0~100 index */
        s8      RxPower; /*  in dBm Translate from PWdB */
 /*  Real power in dBm for this packet, no beautification and aggregation.