[media] cec: Delete an unnecessary check before the function call "rc_free_device"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 17 Jul 2016 20:52:49 +0000 (17:52 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 12:41:10 +0000 (09:41 -0300)
The rc_free_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/cec/cec-core.c

index 112a5fae12f5dd1c11f592c1e3a087d3dc45e84c..80fcb692f4f5f4384abd1cbed57dab54d1f9a9fe 100644 (file)
@@ -354,8 +354,7 @@ void cec_delete_adapter(struct cec_adapter *adap)
        if (adap->kthread_config)
                kthread_stop(adap->kthread_config);
 #if IS_REACHABLE(CONFIG_RC_CORE)
-       if (adap->rc)
-               rc_free_device(adap->rc);
+       rc_free_device(adap->rc);
 #endif
        kfree(adap);
 }