ALSA: firewire-lib: fix uninitialized local variable
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 30 Jan 2023 14:15:32 +0000 (23:15 +0900)
committerTakashi Iwai <tiwai@suse.de>
Tue, 31 Jan 2023 08:32:10 +0000 (09:32 +0100)
The function local variable, curr_cycle_time is declared without
initialization. When tracepoints event is not probed, it looks to be
used as is. This commit fixes it. Fortunately, the value of local variable
is not used unless the event is probed, thus this commit is for better
coding.

Reported-by: Dan Carpenter <error27@gmail.com>
Fixes: fef4e61b0b76 ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20230130141532.102838-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/amdtp-stream.c

index f7e1329efa0b5bc3657562bbcfe6c7112a60f326..a13c0b408aadfcc6d2f1f588cdd96a733961bf2a 100644 (file)
@@ -910,7 +910,7 @@ static int generate_tx_packet_descs(struct amdtp_stream *s, struct pkt_desc *des
        unsigned int dbc = s->data_block_counter;
        unsigned int packet_index = s->packet_index;
        unsigned int queue_size = s->queue_size;
-       u32 curr_cycle_time;
+       u32 curr_cycle_time = 0;
        int i;
        int err;