mlxsw: spectrum: Remove limitation regarding VID 1
authorIdo Schimmel <idosch@mellanox.com>
Thu, 20 Dec 2018 19:42:34 +0000 (19:42 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Dec 2018 23:48:54 +0000 (15:48 -0800)
VID 1 is not reserved anymore, so remove the check that prevented the
creation of VLAN devices with this VID over mlxsw ports.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c

index 0aa8ec402fdcc2449dfa07d2c2406d5a932d4e39..c742a581f0d0a3315c78f4ab034b20a4c3693296 100644 (file)
@@ -4992,11 +4992,6 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev,
                        NL_SET_ERR_MSG_MOD(extack, "Can not put a VLAN on an OVS port");
                        return -EINVAL;
                }
-               if (is_vlan_dev(upper_dev) &&
-                   vlan_dev_vlan_id(upper_dev) == 1) {
-                       NL_SET_ERR_MSG_MOD(extack, "Creating a VLAN device with VID 1 is unsupported: VLAN 1 carries untagged traffic");
-                       return -EINVAL;
-               }
                break;
        case NETDEV_CHANGEUPPER:
                upper_dev = info->upper_dev;