[media] siano: Remove bogus complain about MSG_SMS_DVBT_BDA_DATA
authorMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 19 Mar 2013 16:12:29 +0000 (13:12 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Mar 2013 10:53:59 +0000 (07:53 -0300)
When the driver is tuned into chanel, and it is removed/reinserted,
the message stream data may be arriving during device probe:
[ 5680.162004] smscore_set_device_mode: set device mode to 6
[ 5680.162267] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.162391] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.162641] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.162891] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.163016] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.163266] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.163516] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.163640] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.163891] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.164016] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.164265] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.164515] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.164519] smscore_onresponse: Firmware id 6 prots 0x40 ver 8.1
[ 5680.164766] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.166018] smscore_onresponse: message MSG_SMS_DVBT_BDA_DATA(693) not handled.
[ 5680.166438] DVB: registering new adapter (Siano Rio Digital Receiver)
Instead of complaining, just silently discard those messages, instead of
complaining.
A proper fix is to put the device on suspend/power down mode when the module
is removed.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/siano/smscoreapi.c

index 92eea545ed4edc1a488cc8f1399e0fca3407574f..b5e40aa9651a7fdbbf8bf1e712a2f6ff2b1f84d7 100644 (file)
@@ -1605,6 +1605,15 @@ void smscore_onresponse(struct smscore_device_t *coredev,
                                - sizeof(struct SmsMsgHdr_ST));
                        break;
 
+               case MSG_SMS_DVBT_BDA_DATA:
+                       /*
+                        * It can be received here, if the frontend is
+                        * tuned into a valid channel and the proper firmware
+                        * is loaded. That happens when the module got removed
+                        * and re-inserted, without powering the device off
+                        */
+                       break;
+
                default:
                        sms_debug("message %s(%d) not handled.",
                                  smscore_translate_msg(phdr->msgType),