USB: gadget: imx_udc: Use resource size
authorTobias Klauser <tklauser@distanz.ch>
Fri, 18 Sep 2009 07:14:46 +0000 (09:14 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Oct 2009 20:52:07 +0000 (13:52 -0700)
Use the resource_size function instead of manually calculating the
resource size. This reduces the chance of introducing off-by-one errors.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/gadget/imx_udc.c

index c52a681f376cba495303fe843e9cd0839a15a234..01ee0b9bc9575e7e8902fd67a66bea7ae4234fff 100644 (file)
@@ -1402,7 +1402,8 @@ static int __init imx_udc_probe(struct platform_device *pdev)
        struct clk *clk;
        void __iomem *base;
        int ret = 0;
-       int i, res_size;
+       int i;
+       resource_size_t res_size;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res) {
@@ -1416,7 +1417,7 @@ static int __init imx_udc_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       res_size = res->end - res->start + 1;
+       res_size = resource_size(res);
        if (!request_mem_region(res->start, res_size, res->name)) {
                dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n",
                        res_size, res->start);
@@ -1527,8 +1528,7 @@ static int __exit imx_udc_remove(struct platform_device *pdev)
        clk_disable(imx_usb->clk);
        iounmap(imx_usb->base);
 
-       release_mem_region(imx_usb->res->start,
-               imx_usb->res->end - imx_usb->res->start + 1);
+       release_mem_region(imx_usb->res->start, resource_size(imx_usb->res));
 
        if (pdata->exit)
                pdata->exit(&pdev->dev);