perf top: Display slow reader warning when droping samples
authorJiri Olsa <jolsa@kernel.org>
Mon, 19 Nov 2018 10:12:01 +0000 (11:12 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 Dec 2018 17:58:40 +0000 (14:58 -0300)
Currently we display the "Too slow to read ring buffer.." helpline only
in the slow reader thread. This patch triggers it also when the
processing thread drops samples, because it has the same reason, which
is too many data on input.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/n/tip-bnev2mloavyurmgchcr3o24o@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c

index 9166f6087e3f02ce9b66a57c1c6d675cf5c9a140..f22c531be3660a0b7d667ea0067d5bbd3350d464 100644 (file)
@@ -571,7 +571,7 @@ static void perf_top__sort_new_samples(void *arg)
        hists__collapse_resort(hists, NULL);
        perf_evsel__output_resort(evsel, NULL);
 
-       if (t->lost)
+       if (t->lost || t->drop)
                pr_warning("Too slow to read ring buffer (change period (-c/-F) or limit CPUs (-C)\n");
 
        perf_top__reset_sample_counters(t);