drm/i915/display: use drm_print_hex_dump() for buffer mismatch dumps
authorJani Nikula <jani.nikula@intel.com>
Thu, 5 Dec 2024 09:49:35 +0000 (11:49 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 10 Dec 2024 12:09:04 +0000 (14:09 +0200)
Use the drm_printer based printer to get the device specific printing of
the hex dump, and avoid the manual loglevel hacking.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/a536050b5f9dc2d7de32d29766c98477f58d746c.1733392101.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display.c

index 35c8904ecf443524fcded93874e072a98564a4b0..8e90e99a25d646636470f11c5892ac9f381f9cba 100644 (file)
@@ -5268,26 +5268,13 @@ pipe_config_buffer_mismatch(struct drm_printer *p, bool fastset,
                            const char *name,
                            const u8 *a, const u8 *b, size_t len)
 {
-       const char *loglevel;
-
-       if (fastset) {
-               if (!drm_debug_enabled(DRM_UT_KMS))
-                       return;
-
-               loglevel = KERN_DEBUG;
-       } else {
-               loglevel = KERN_ERR;
-       }
-
        pipe_config_mismatch(p, fastset, crtc, name, "buffer");
 
        /* only dump up to the last difference */
        len = memcmp_diff_len(a, b, len);
 
-       print_hex_dump(loglevel, "expected: ", DUMP_PREFIX_NONE,
-                      16, 0, a, len, false);
-       print_hex_dump(loglevel, "found: ", DUMP_PREFIX_NONE,
-                      16, 0, b, len, false);
+       drm_print_hex_dump(p, "expected: ", a, len);
+       drm_print_hex_dump(p, "found:    ", b, len);
 }
 
 static void