cifs: Use kmemdup in SMB2_ioctl_init()
authorYueHaibing <yuehaibing@huawei.com>
Sat, 1 Jun 2019 03:31:10 +0000 (03:31 +0000)
committerSteve French <stfrench@microsoft.com>
Mon, 8 Jul 2019 03:37:42 +0000 (22:37 -0500)
Use kmemdup rather than duplicating its implementation

This was reported by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2pdu.c

index 75311a8a68bfd1941413e02a8739f9256c21bb3f..ab8dc73d2282801a0f9c3549ff30bd3dd62d13c5 100644 (file)
@@ -2550,12 +2550,11 @@ SMB2_ioctl_init(struct cifs_tcon *tcon, struct smb_rqst *rqst,
                 * indatalen is usually small at a couple of bytes max, so
                 * just allocate through generic pool
                 */
-               in_data_buf = kmalloc(indatalen, GFP_NOFS);
+               in_data_buf = kmemdup(in_data, indatalen, GFP_NOFS);
                if (!in_data_buf) {
                        cifs_small_buf_release(req);
                        return -ENOMEM;
                }
-               memcpy(in_data_buf, in_data, indatalen);
        }
 
        req->CtlCode = cpu_to_le32(opcode);