rtw88: Remove unnecessary check code

The rtw_pci_init_rx_ring function is only ever called with a fixed
constant or RTK_MAX_RX_DESC_NUM for the "len" argument. Since this
constant is defined as 512, the "if (len > TRX_BD_IDX_MASK)" check
can never happen (TRX_BD_IDX_MASK is defined as GENMASK(11, 0) or in
other words as 4095).

So, remove this check.

The true motivation for this patch is to silence a false Coverity
warning.

Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Len Baker <len.baker@gmx.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210731163546.10753-1-len.baker@gmx.com

diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index 0f95a9555aea7f0c8c4ba38ffbd09a5b7912b217..cfb9f1ea30a0624f1456024d98b3cc1bf611eee4 100644 (file)
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -268,11 +268,6 @@ static int rtw_pci_init_rx_ring(struct rtw_dev *rtwdev,
        int i, allocated;
        int ret = 0;
 
-       if (len > TRX_BD_IDX_MASK) {
-               rtw_err(rtwdev, "len %d exceeds maximum RX entries\n", len);
-               return -EINVAL;
-       }
-
        head = dma_alloc_coherent(&pdev->dev, ring_sz, &dma, GFP_KERNEL);
        if (!head) {
                rtw_err(rtwdev, "failed to allocate rx ring\n");