ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handler()
authorNathan Chancellor <nathan@kernel.org>
Mon, 25 Jul 2022 18:05:39 +0000 (11:05 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 26 Jul 2022 12:02:25 +0000 (13:02 +0100)
Clang warns:

  ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized]
                          if (stream && (ext_intr_stat1 & stream->irq_bit)) {
                                         ^~~~~~~~~~~~~~
  ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning
          u32 ext_intr_stat, ext_intr_stat1, i;
                                           ^
                                            = 0
  1 error generated.

The variable was not properly renamed, correct it to resolve the
warning.

Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic")
Link: https://github.com/ClangBuiltLinux/linux/issues/1675
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20220725180539.1315066-1-nathan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-platform.c

index 10730d33c3b0faf1c0f4a6d837c622c0d4c61e5f..f561d39b33e2adb8638f36aada844ed609554c3e 100644 (file)
@@ -100,7 +100,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
                return IRQ_NONE;
 
        if (adata->rsrc->no_of_ctrls == 2)
-               ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
+               ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
 
        ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));