ASoC: codecs: wsa884x: report temps to hwmon in millidegree of Celsius
authorAlexey Klimov <alexey.klimov@linaro.org>
Fri, 21 Feb 2025 04:40:24 +0000 (04:40 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 3 Mar 2025 13:03:09 +0000 (13:03 +0000)
Temperatures are reported in units of Celsius however hwmon expects
values to be in millidegree of Celsius. Userspace tools observe values
close to zero and report it as "Not available" or incorrect values like
0C or 1C. Add a simple conversion to fix that.

Before the change:

wsa884x-virtual-0
Adapter: Virtual device
temp1:         +0.0°C
--
wsa884x-virtual-0
Adapter: Virtual device
temp1:         +0.0°C

Also reported as N/A before first amplifier power on.

After this change and initial wsa884x power on:

wsa884x-virtual-0
Adapter: Virtual device
temp1:        +39.0°C
--
wsa884x-virtual-0
Adapter: Virtual device
temp1:        +37.0°C

Tested on sm8550 only.

Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
Link: https://patch.msgid.link/20250221044024.1207921-1-alexey.klimov@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wsa884x.c

index 86df5152c547bc5abd005a37f0418b8bef76cf59..560a2c04b695535c42bb59b17aa8a671247adf95 100644 (file)
@@ -1875,7 +1875,7 @@ static int wsa884x_get_temp(struct wsa884x_priv *wsa884x, long *temp)
                 * Reading temperature is possible only when Power Amplifier is
                 * off. Report last cached data.
                 */
-               *temp = wsa884x->temperature;
+               *temp = wsa884x->temperature * 1000;
                return 0;
        }
 
@@ -1934,7 +1934,7 @@ static int wsa884x_get_temp(struct wsa884x_priv *wsa884x, long *temp)
        if ((val > WSA884X_LOW_TEMP_THRESHOLD) &&
            (val < WSA884X_HIGH_TEMP_THRESHOLD)) {
                wsa884x->temperature = val;
-               *temp = val;
+               *temp = val * 1000;
                ret = 0;
        } else {
                ret = -EAGAIN;