tracing: convert irq trace points to new macros
authorSteven Rostedt <srostedt@redhat.com>
Tue, 10 Mar 2009 03:23:30 +0000 (23:23 -0400)
committerSteven Rostedt <srostedt@redhat.com>
Tue, 10 Mar 2009 04:35:11 +0000 (00:35 -0400)
Impact: enhancement

Converted the two irq trace point macros. The entry macro copies
the name of the irq handler, thus it is better to simply use the
TRACE_FORMAT macro which uses the trace_printk.

The return of the handler does not need to record the name, thus
the faster C style handler is more approriate.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
include/trace/irq_event_types.h

index 0147d9eef5f41e436e9a04fd6fae56b5ccc5a676..43bcb74dd49f4272f4398d7ceef1de6acaf2dcf6 100644 (file)
@@ -8,26 +8,36 @@
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM irq
 
-TRACE_EVENT_FORMAT(irq_handler_entry,
+/*
+ * Tracepoint for entry of interrupt handler:
+ */
+TRACE_FORMAT(irq_handler_entry,
        TP_PROTO(int irq, struct irqaction *action),
        TP_ARGS(irq, action),
-       TP_FMT("irq=%d handler=%s", irq, action->name),
-       TRACE_STRUCT(
-               TRACE_FIELD(int, irq, irq)
-       ),
-       TP_RAW_FMT("irq %d")
+       TP_FMT("irq=%d handler=%s", irq, action->name)
        );
 
-TRACE_EVENT_FORMAT(irq_handler_exit,
+/*
+ * Tracepoint for return of an interrupt handler:
+ */
+TRACE_EVENT(irq_handler_exit,
+
        TP_PROTO(int irq, struct irqaction *action, int ret),
+
        TP_ARGS(irq, action, ret),
-       TP_FMT("irq=%d handler=%s return=%s",
-               irq, action->name, ret ? "handled" : "unhandled"),
-       TRACE_STRUCT(
-               TRACE_FIELD(int, irq, irq)
-               TRACE_FIELD(int, ret, ret)
+
+       TP_STRUCT__entry(
+               __field(        int,    irq     )
+               __field(        int,    ret     )
        ),
-       TP_RAW_FMT("irq %d ret %d")
-       );
+
+       TP_printk("irq=%d return=%s",
+                 __entry->irq, __entry->ret ? "handled" : "unhandled"),
+
+       TP_fast_assign(
+               __entry->irq    = irq;
+               __entry->ret    = ret;
+       )
+);
 
 #undef TRACE_SYSTEM