staging: rtl8723bs: Remove function pointer free_xmit_priv
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Sat, 5 Oct 2024 20:33:48 +0000 (22:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Oct 2024 09:48:52 +0000 (11:48 +0200)
Remove function pointer free_xmit_priv and use rtl8723bs_free_xmit_priv
directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/01ee48c459ddda882c7616e6cf257d96429027c2.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/hal_intf.c
drivers/staging/rtl8723bs/hal/sdio_halinit.c
drivers/staging/rtl8723bs/include/hal_intf.h

index 1d1e4f438e7b8ca61acf18dd281d71779c9bc277..bbead941289d58c51dedb61a22ef84fac1e40eca 100644 (file)
@@ -225,8 +225,7 @@ s32 rtw_hal_init_xmit_priv(struct adapter *padapter)
 
 void rtw_hal_free_xmit_priv(struct adapter *padapter)
 {
-       if (padapter->HalFunc.free_xmit_priv)
-               padapter->HalFunc.free_xmit_priv(padapter);
+       rtl8723bs_free_xmit_priv(padapter);
 }
 
 s32    rtw_hal_init_recv_priv(struct adapter *padapter)
index 55cf827fc255814d7f51deae22374a501018ca5c..ef70ada68f2c88c34b27381472f239647902ae4a 100644 (file)
@@ -1259,8 +1259,6 @@ void rtl8723bs_set_hal_ops(struct adapter *padapter)
 
        rtl8723b_set_hal_ops(pHalFunc);
 
-       pHalFunc->free_xmit_priv = &rtl8723bs_free_xmit_priv;
-
        pHalFunc->init_recv_priv = &rtl8723bs_init_recv_priv;
        pHalFunc->free_recv_priv = &rtl8723bs_free_recv_priv;
 
index 696a71c01bf9f11d53ea4282c4f53ee3c233c99e..0782a13074d76d78daca9c9945af9ee8d080b660 100644 (file)
@@ -162,8 +162,6 @@ enum hal_intf_ps_func {
 typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 
 struct hal_ops {
-       void (*free_xmit_priv)(struct adapter *padapter);
-
        s32     (*init_recv_priv)(struct adapter *padapter);
        void (*free_recv_priv)(struct adapter *padapter);