nvme-pci: remove redundant dma frees in hmb
authorFrancis Pravin <francis.p@samsung.com>
Thu, 16 Jan 2025 23:42:09 +0000 (05:12 +0530)
committerKeith Busch <kbusch@kernel.org>
Fri, 17 Jan 2025 19:16:34 +0000 (11:16 -0800)
The value of size is 0 when there is no dma buffer allocated. The value
of i also remains 0. So, no need to free the dma buffer in out_free_bufs.
Hence, remove the redundant dma frees.

Signed-off-by: Francis Pravin <francis.p@samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/pci.c

index fe0795e16e250a2bd5d9ef51c0044b34f9ee70b1..a14f3c74b71718e98006df259108cd6fa8c62d77 100644 (file)
@@ -2153,14 +2153,6 @@ static int nvme_alloc_host_mem_multi(struct nvme_dev *dev, u64 preferred,
        return 0;
 
 out_free_bufs:
-       while (--i >= 0) {
-               size_t size = le32_to_cpu(descs[i].size) * NVME_CTRL_PAGE_SIZE;
-
-               dma_free_attrs(dev->dev, size, bufs[i],
-                              le64_to_cpu(descs[i].addr),
-                              DMA_ATTR_NO_KERNEL_MAPPING | DMA_ATTR_NO_WARN);
-       }
-
        kfree(bufs);
 out_free_descs:
        dma_free_coherent(dev->dev, descs_size, descs, descs_dma);