nvme: fix NULL derefence in nvme_ctrl_fast_io_fail_tmo_show/store
authorGopal Tiwari <gtiwari@redhat.com>
Wed, 14 Apr 2021 08:46:45 +0000 (14:16 +0530)
committerChristoph Hellwig <hch@lst.de>
Thu, 15 Apr 2021 06:12:56 +0000 (08:12 +0200)
Adding entry for dev_attr_fast_io_fail_tmo to avoid the kernel crash
while reading and writing the fast_io_fail_tmo.

Fixes: 09fbed636382 (nvme: export fast_io_fail_tmo to sysfs)
Signed-off-by: Gopal Tiwari <gtiwari@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index 288ac47ff5b47091db5c7d91d7ba7f029855fa9a..40f08e6325ef04358c5ad60d3f12825bacb1887a 100644 (file)
@@ -3379,6 +3379,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
                return 0;
        if (a == &dev_attr_reconnect_delay.attr && !ctrl->opts)
                return 0;
+       if (a == &dev_attr_fast_io_fail_tmo.attr && !ctrl->opts)
+               return 0;
 
        return a->mode;
 }