scsi: qla2xxx: Do not call abort handler function during chip reset
authorSawan Chandak <sawan.chandak@cavium.com>
Wed, 23 Aug 2017 22:05:24 +0000 (15:05 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2017 02:29:33 +0000 (22:29 -0400)
If there are IO's running and host reset or chip reset is triggered,
IO's can fail due to rport time out. During chip reset recovery process,
driver notifies the transport layer that remote port no longer exist, by
calling fc_remote_port_delete(). When this function is called, it
actually delays deletion by "blocking" it. It sets the remote port state
to "FC_PORTSTATE_BLOCKED" and sets FC_RPORT_DEVLOSS_PENDING.  When
driver tries to abort the command by calling its abort handler function,
abort handler will wait until remote port state is blocked state or wait
for dev_loss_tmo time. Due to this blocking, rport times out and results
in an IO failure. This patch adds a check for any active reset process
before calling abort handler function.

[mkp: typo]

Signed-off-by: Sawan Chandak <sawan.chandak@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c

index 715427f8e732642fd0475b3fdda48384df358e33..56bd086b79ea140db249ac23dd72822bb705e639 100644 (file)
@@ -1732,6 +1732,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res)
                                                    &ha->hardware_lock, flags);
                                        } else if (GET_CMD_SP(sp) &&
                                            !ha->flags.eeh_busy &&
+                                           (!test_bit(ABORT_ISP_ACTIVE,
+                                               &vha->dpc_flags)) &&
                                            (sp->type == SRB_SCSI_CMD)) {
                                                /*
                                                 * Don't abort commands in