mmc: sh_mmcif: correctly report success when obtaining DMA channels

The debug message could still report success when getting the channels
was OK but configuring them failed. This actually caused a minor detour
when debugging DMA problems, so make sure the success is only reported
when the channels are really ready-to-use.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240928094454.3592-2-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 864e345a39f6322e5db8b379f8733c64941f77ec..ce60cec26b985d7cf80369b6125ea73da658b561 100644 (file)
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -439,14 +439,15 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host *host)
                if (IS_ERR(host->chan_rx))
                        host->chan_rx = NULL;
        }
-       dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
-               host->chan_rx);
 
        if (!host->chan_tx || !host->chan_rx ||
            sh_mmcif_dma_slave_config(host, host->chan_tx, DMA_MEM_TO_DEV) ||
            sh_mmcif_dma_slave_config(host, host->chan_rx, DMA_DEV_TO_MEM))
                goto error;
 
+       dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
+               host->chan_rx);
+
        return;
 
 error: