ext4: avoid -Wformat-security warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 23 Apr 2025 16:43:49 +0000 (18:43 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 16 May 2025 18:44:59 +0000 (14:44 -0400)
check_igot_inode() prints a variable string, which causes a harmless
warning with 'make W=1':

fs/ext4/inode.c:4763:45: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
 4763 |         ext4_error_inode(inode, function, line, 0, err_str);

Use a trivial "%s" format string instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20250423164354.2780635-1-arnd@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c

index 9b0bfbbdb50b9cb2f96f02fa7e6ac5e0db4c6a50..7237b63267223d856064aca859664ec8a943779d 100644 (file)
@@ -4809,7 +4809,7 @@ static int check_igot_inode(struct inode *inode, ext4_iget_flags flags,
        return 0;
 
 error:
-       ext4_error_inode(inode, function, line, 0, err_str);
+       ext4_error_inode(inode, function, line, 0, "%s", err_str);
        return -EFSCORRUPTED;
 }