nfp: correct DMA direction in XDP DMA sync
authorJakub Kicinski <jakub.kicinski@netronome.com>
Thu, 2 Mar 2017 23:26:21 +0000 (15:26 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Mar 2017 17:46:53 +0000 (09:46 -0800)
dma_sync_single_for_*() takes the direction in which the buffer
was mapped, not the direction of the sync.  We should sync XDP
buffers bidirectionally.

Fixes: ecd63a0217d5 ("nfp: add XDP support in the driver")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c

index 00a83218857a97d48f5fcc69642615065ac15db9..9179a99563afa86f4ed7bbcb41b045c2568243de 100644 (file)
@@ -1498,7 +1498,7 @@ nfp_net_tx_xdp_buf(struct nfp_net *nn, struct nfp_net_rx_ring *rx_ring,
        txbuf->real_len = pkt_len;
 
        dma_sync_single_for_device(&nn->pdev->dev, rxbuf->dma_addr + pkt_off,
-                                  pkt_len, DMA_TO_DEVICE);
+                                  pkt_len, DMA_BIDIRECTIONAL);
 
        /* Build TX descriptor */
        txd = &tx_ring->txds[wr_idx];
@@ -1611,7 +1611,7 @@ static int nfp_net_rx(struct nfp_net_rx_ring *rx_ring, int budget)
 
                        dma_sync_single_for_cpu(&nn->pdev->dev,
                                                rxbuf->dma_addr + pkt_off,
-                                               pkt_len, DMA_FROM_DEVICE);
+                                               pkt_len, DMA_BIDIRECTIONAL);
                        act = nfp_net_run_xdp(xdp_prog, rxbuf->frag + data_off,
                                              pkt_len);
                        switch (act) {