scsi: cxlflash: Limit the debug logs in the IO path
authorUma Krishnan <ukrishn@linux.vnet.ibm.com>
Fri, 11 May 2018 19:05:08 +0000 (14:05 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 18 May 2018 15:22:10 +0000 (11:22 -0400)
The kernel log can get filled with debug messages from send_cmd_ioarrin()
when dynamic debug is enabled for the cxlflash module and there is a lot of
legacy I/O traffic.

While these messages are necessary to debug issues that involve command
tracking, the abundance of data can overwrite other useful data in the
log. The best option available is to limit the messages that should serve
most of the common use cases.

Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/main.c

index dad2be6c29c3558272aee1e3d22b350fe94f7f06..cf0b407f6ebbd990abdaf8872ddc6262fef14fd8 100644 (file)
@@ -339,8 +339,8 @@ static int send_cmd_ioarrin(struct afu *afu, struct afu_cmd *cmd)
        writeq_be((u64)&cmd->rcb, &hwq->host_map->ioarrin);
 out:
        spin_unlock_irqrestore(&hwq->hsq_slock, lock_flags);
-       dev_dbg(dev, "%s: cmd=%p len=%u ea=%016llx rc=%d\n", __func__,
-               cmd, cmd->rcb.data_len, cmd->rcb.data_ea, rc);
+       dev_dbg_ratelimited(dev, "%s: cmd=%p len=%u ea=%016llx rc=%d\n",
+               __func__, cmd, cmd->rcb.data_len, cmd->rcb.data_ea, rc);
        return rc;
 }