dmaengine: idxd: Add missing idxd cleanup to fix memory leak in remove call
authorShuai Xue <xueshuai@linux.alibaba.com>
Fri, 4 Apr 2025 12:02:16 +0000 (20:02 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 14 May 2025 13:40:40 +0000 (14:40 +0100)
The remove call stack is missing idxd cleanup to free bitmap, ida and
the idxd_device. Call idxd_free() helper routines to make sure we exit
gracefully.

Fixes: bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data accelerators")
Cc: stable@vger.kernel.org
Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20250404120217.48772-9-xueshuai@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/init.c

index f2b5b17538c06961e6a6222b24d383e5cb850152..974b926bd93009ce75d1b292ead4a12f79d23e19 100644 (file)
@@ -1335,6 +1335,7 @@ static void idxd_remove(struct pci_dev *pdev)
        destroy_workqueue(idxd->wq);
        perfmon_pmu_remove(idxd);
        put_device(idxd_confdev(idxd));
+       idxd_free(idxd);
 }
 
 static struct pci_driver idxd_pci_driver = {