[SCSI] libosd: osd_dev_is_ver1 - Minor API cleanup
authorBoaz Harrosh <bharrosh@panasas.com>
Mon, 16 Nov 2009 18:39:25 +0000 (20:39 +0200)
committerJames Bottomley <James.Bottomley@suse.de>
Fri, 4 Dec 2009 18:01:44 +0000 (12:01 -0600)
define a new osd_dev_is_ver1 that operates on devices
and the old osd_req_is_ver1 uses that new API.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
include/scsi/osd_initiator.h

index 02bd9f7163570512e19c0e98e17295a5f47561e8..f787d24d3baba4f23f194125113d8eeed6327741 100644 (file)
@@ -84,6 +84,15 @@ static inline void osd_dev_set_ver(struct osd_dev *od, enum osd_std_version v)
 #endif
 }
 
+static inline bool osd_dev_is_ver1(struct osd_dev *od)
+{
+#ifdef OSD_VER1_SUPPORT
+       return od->version == OSD_VER1;
+#else
+       return false;
+#endif
+}
+
 struct osd_request;
 typedef void (osd_req_done_fn)(struct osd_request *or, void *private);
 
@@ -120,14 +129,9 @@ struct osd_request {
        int async_error;
 };
 
-/* OSD Version control */
 static inline bool osd_req_is_ver1(struct osd_request *or)
 {
-#ifdef OSD_VER1_SUPPORT
-       return or->osd_dev->version == OSD_VER1;
-#else
-       return false;
-#endif
+       return osd_dev_is_ver1(or->osd_dev);
 }
 
 /*