ide: missing break statement in set_timings_mdma()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 Jul 2016 10:48:02 +0000 (13:48 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Jul 2016 22:25:31 +0000 (15:25 -0700)
There was clearly supposed to be a break statement here.  Currently we
use the k2 ata timings instead of sh ata ones we intended.  Probably no
one has this hardware anymore so it likely doesn't make a difference
beyond the static checker warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/pmac.c

index 7f0434f7e486666be6052e1c11c98c16f8f25174..0c5d3a99468e6087b18d6c86706ffee02568057b 100644 (file)
@@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
                *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
                *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
                }
+               break;
        case controller_un_ata6:
        case controller_k2_ata6: {
                /* 100Mhz cell */