RDMA/hns: Fix error with to_hr_hem_entries_count()
authorWeihang Li <liweihang@huawei.com>
Fri, 8 May 2020 09:45:55 +0000 (17:45 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 19 May 2020 23:54:58 +0000 (20:54 -0300)
For ilog2(x), if x is 0 and not a constant variable, it will return
-1. And there will be an error as below:

 hns3 0000:7d:00.0 hns_0: Local work queue 0x8 catast error, sub_event type is: 2

So modify to_hr_hem_entries_shift() to return 0 if conut is 0.

Fixes: 54d6638765b0 ("RDMA/hns: Optimize WQE buffer size calculating process")
Link: https://lore.kernel.org/r/1588931159-56875-6-git-send-email-liweihang@huawei.com
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_device.h

index 4fcd608ee55f28320b8a7550e79e4eff568ab18c..770a6d5517d5843bcff5a9f5c934a627d4f3f5f8 100644 (file)
@@ -1112,6 +1112,9 @@ static inline u32 to_hr_hem_entries_count(u32 count, u32 buf_shift)
 
 static inline u32 to_hr_hem_entries_shift(u32 count, u32 buf_shift)
 {
+       if (!count)
+               return 0;
+
        return ilog2(to_hr_hem_entries_count(count, buf_shift));
 }