firewire: ohci: replace request_irq() with request_threaded_irq()
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 31 Mar 2024 13:50:35 +0000 (22:50 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 6 May 2024 02:06:04 +0000 (11:06 +0900)
Nowadays request_irq() is a wrapper of request_threaded_irq(). The IRQ
handler of 1394 ohci driver has never been optimized yet, while it is
a good preparation for the future work to replace the latter.

This commit replaces the former.

Link: https://lore.kernel.org/r/20240331135037.191479-3-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/ohci.c

index c1ee16c3b424a32243e32a520526d845c315169b..0f55ef43292f2f88725f81191d25fdb77a0eaf2c 100644 (file)
@@ -3758,11 +3758,11 @@ static int pci_probe(struct pci_dev *dev,
 
        if (!(ohci->quirks & QUIRK_NO_MSI))
                pci_enable_msi(dev);
-       if (request_irq(dev->irq, irq_handler,
-                       pci_dev_msi_enabled(dev) ? 0 : IRQF_SHARED,
-                       ohci_driver_name, ohci)) {
+       err = request_threaded_irq(dev->irq, irq_handler, NULL,
+                                  pci_dev_msi_enabled(dev) ? 0 : IRQF_SHARED, ohci_driver_name,
+                                  ohci);
+       if (err < 0) {
                ohci_err(ohci, "failed to allocate interrupt %d\n", dev->irq);
-               err = -EIO;
                goto fail_msi;
        }