nfp: Use skb_put_data() instead of skb_put/memcpy pair
authorShang XiaoJing <shangxiaojing@huawei.com>
Tue, 27 Sep 2022 14:18:35 +0000 (22:18 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 Sep 2022 08:46:42 +0000 (10:46 +0200)
Use skb_put_data() instead of skb_put() and memcpy(), which is clear.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Link: https://lore.kernel.org/r/20220927141835.19221-1-shangxiaojing@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/netronome/nfp/nfd3/xsk.c

index 65e24316876551b0262950a21adbe5a0c3741afa..5d9db8c2a5b437c5e2032e4a17d055bf620d9c82 100644 (file)
@@ -84,7 +84,7 @@ static void nfp_nfd3_xsk_rx_skb(struct nfp_net_rx_ring *rx_ring,
                nfp_net_xsk_rx_drop(r_vec, xrxbuf);
                return;
        }
-       memcpy(skb_put(skb, pkt_len), xrxbuf->xdp->data, pkt_len);
+       skb_put_data(skb, xrxbuf->xdp->data, pkt_len);
 
        skb->mark = meta->mark;
        skb_set_hash(skb, meta->hash, meta->hash_type);