wifi: rtlwifi: Remove some exhalbtc deadcode
authorDr. David Alan Gilbert <linux@treblig.org>
Mon, 4 Nov 2024 14:43:31 +0000 (14:43 +0000)
committerPing-Ke Shih <pkshih@realtek.com>
Wed, 6 Nov 2024 06:35:54 +0000 (14:35 +0800)
exhalbtc_rf_status_notify(), exhalbtc_coex_dm_switch() and
exhalbtc_antenna_detection() are unused since they were added in 2017's
commit 7937f02d1953 ("rtlwifi: btcoex: hook external functions for newer
chips")

Remove them.

This leaves ex_btc8723b1ant_coex_dm_reset() unused.

Remove it.

exhalbtc_dbg_control(), exhalbtc_stack_update_profile_info(),
exhalbtc_set_hci_version(), and exhalbtc_set_bt_patch_version() are
unused since their addition in 2014 by
commit aa45a673b291 ("rtlwifi: btcoexist: Add new mini driver")

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241104144331.29262-1-linux@treblig.org
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.h
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h

index 039bbedb41c2459ca5ac6ddba5f428b2ea3b20cc..379193b2442879a0b95d3f62e4d8fad1a2b5c22e 100644 (file)
@@ -3409,17 +3409,6 @@ void ex_btc8723b1ant_pnp_notify(struct btc_coexist *btcoexist, u8 pnp_state)
        }
 }
 
-void ex_btc8723b1ant_coex_dm_reset(struct btc_coexist *btcoexist)
-{
-       struct rtl_priv *rtlpriv = btcoexist->adapter;
-
-       rtl_dbg(rtlpriv, COMP_BT_COEXIST, DBG_LOUD,
-               "[BTCoex], *****************Coex DM Reset****************\n");
-
-       halbtc8723b1ant_init_hw_config(btcoexist, false, false);
-       halbtc8723b1ant_init_coex_dm(btcoexist);
-}
-
 void ex_btc8723b1ant_periodical(struct btc_coexist *btcoexist)
 {
        struct rtl_priv *rtlpriv = btcoexist->adapter;
index 9d41e11388ade2e9c1a765b77e419e067508d1ea..a4506d838dc74e74986a7c7daa28fc6348f0dd79 100644 (file)
@@ -197,7 +197,6 @@ void ex_btc8723b1ant_rf_status_notify(struct btc_coexist *btcoexist,
                                      u8 type);
 void ex_btc8723b1ant_halt_notify(struct btc_coexist *btcoexist);
 void ex_btc8723b1ant_pnp_notify(struct btc_coexist *btcoexist, u8 pnpstate);
-void ex_btc8723b1ant_coex_dm_reset(struct btc_coexist *btcoexist);
 void ex_btc8723b1ant_periodical(struct btc_coexist *btcoexist);
 void ex_btc8723b1ant_display_coex_info(struct btc_coexist *btcoexist,
                                       struct seq_file *m);
index be4c0e60d44d19dbbd13b74850551b739dc86479..478cca33e5e3153232899d2a190379546d4e0b8f 100644 (file)
@@ -1708,19 +1708,6 @@ void exhalbtc_bt_info_notify(struct btc_coexist *btcoexist,
        halbtc_normal_low_power(btcoexist);
 }
 
-void exhalbtc_rf_status_notify(struct btc_coexist *btcoexist, u8 type)
-{
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-
-       if (IS_HARDWARE_TYPE_8821(btcoexist->adapter)) {
-       } else if (IS_HARDWARE_TYPE_8723B(btcoexist->adapter)) {
-               if (btcoexist->board_info.btdm_ant_num == 1)
-                       ex_btc8723b1ant_rf_status_notify(btcoexist, type);
-       } else if (IS_HARDWARE_TYPE_8192E(btcoexist->adapter)) {
-       }
-}
-
 void exhalbtc_halt_notify(struct btc_coexist *btcoexist)
 {
        if (!halbtc_is_bt_coexist_available(btcoexist))
@@ -1768,31 +1755,6 @@ void exhalbtc_pnp_notify(struct btc_coexist *btcoexist, u8 pnp_state)
        }
 }
 
-void exhalbtc_coex_dm_switch(struct btc_coexist *btcoexist)
-{
-       struct rtl_priv *rtlpriv = btcoexist->adapter;
-
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-       btcoexist->statistics.cnt_coex_dm_switch++;
-
-       halbtc_leave_low_power(btcoexist);
-
-       if (IS_HARDWARE_TYPE_8723B(btcoexist->adapter)) {
-               if (btcoexist->board_info.btdm_ant_num == 1) {
-                       btcoexist->stop_coex_dm = true;
-                       ex_btc8723b1ant_coex_dm_reset(btcoexist);
-                       exhalbtc_set_ant_num(rtlpriv,
-                                            BT_COEX_ANT_TYPE_DETECTED, 2);
-                       ex_btc8723b2ant_init_hwconfig(btcoexist);
-                       ex_btc8723b2ant_init_coex_dm(btcoexist);
-                       btcoexist->stop_coex_dm = false;
-               }
-       }
-
-       halbtc_normal_low_power(btcoexist);
-}
-
 void exhalbtc_periodical(struct btc_coexist *btcoexist)
 {
        if (!halbtc_is_bt_coexist_available(btcoexist))
@@ -1820,29 +1782,6 @@ void exhalbtc_periodical(struct btc_coexist *btcoexist)
        halbtc_normal_low_power(btcoexist);
 }
 
-void exhalbtc_dbg_control(struct btc_coexist *btcoexist,
-                         u8 code, u8 len, u8 *data)
-{
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-       btcoexist->statistics.cnt_dbg_ctrl++;
-
-       halbtc_leave_low_power(btcoexist);
-
-       halbtc_normal_low_power(btcoexist);
-}
-
-void exhalbtc_antenna_detection(struct btc_coexist *btcoexist, u32 cent_freq,
-                               u32 offset, u32 span, u32 seconds)
-{
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-}
-
-void exhalbtc_stack_update_profile_info(void)
-{
-}
-
 void exhalbtc_update_min_bt_rssi(struct btc_coexist *btcoexist, s8 bt_rssi)
 {
        if (!halbtc_is_bt_coexist_available(btcoexist))
@@ -1851,24 +1790,6 @@ void exhalbtc_update_min_bt_rssi(struct btc_coexist *btcoexist, s8 bt_rssi)
        btcoexist->stack_info.min_bt_rssi = bt_rssi;
 }
 
-void exhalbtc_set_hci_version(struct btc_coexist *btcoexist, u16 hci_version)
-{
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-
-       btcoexist->stack_info.hci_version = hci_version;
-}
-
-void exhalbtc_set_bt_patch_version(struct btc_coexist *btcoexist,
-                                  u16 bt_hci_version, u16 bt_patch_version)
-{
-       if (!halbtc_is_bt_coexist_available(btcoexist))
-               return;
-
-       btcoexist->bt_info.bt_real_fw_ver = bt_patch_version;
-       btcoexist->bt_info.bt_hci_ver = bt_hci_version;
-}
-
 void exhalbtc_set_chip_type(struct btc_coexist *btcoexist, u8 chip_type)
 {
        switch (chip_type) {
index a96a995dd850732d6578fa2cd8dd157d548fbe7c..d8d88a98980601d4dc10c512761a58d029858444 100644 (file)
@@ -763,19 +763,9 @@ void exhalbtc_mediastatus_notify(struct btc_coexist *btcoexist,
 void exhalbtc_special_packet_notify(struct btc_coexist *btcoexist, u8 pkt_type);
 void exhalbtc_bt_info_notify(struct btc_coexist *btcoexist, u8 *tmp_buf,
                             u8 length);
-void exhalbtc_rf_status_notify(struct btc_coexist *btcoexist, u8 type);
 void exhalbtc_halt_notify(struct btc_coexist *btcoexist);
 void exhalbtc_pnp_notify(struct btc_coexist *btcoexist, u8 pnp_state);
-void exhalbtc_coex_dm_switch(struct btc_coexist *btcoexist);
 void exhalbtc_periodical(struct btc_coexist *btcoexist);
-void exhalbtc_dbg_control(struct btc_coexist *btcoexist, u8 code, u8 len,
-                         u8 *data);
-void exhalbtc_antenna_detection(struct btc_coexist *btcoexist, u32 cent_freq,
-                               u32 offset, u32 span, u32 seconds);
-void exhalbtc_stack_update_profile_info(void);
-void exhalbtc_set_hci_version(struct btc_coexist *btcoexist, u16 hci_version);
-void exhalbtc_set_bt_patch_version(struct btc_coexist *btcoexist,
-                                  u16 bt_hci_version, u16 bt_patch_version);
 void exhalbtc_update_min_bt_rssi(struct btc_coexist *btcoexist, s8 bt_rssi);
 void exhalbtc_set_bt_exist(struct btc_coexist *btcoexist, bool bt_exist);
 void exhalbtc_set_chip_type(struct btc_coexist *btcoexist, u8 chip_type);