virtio: clean up handling of request_irq failure
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 15 Dec 2016 21:58:13 +0000 (23:58 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 15 Dec 2016 22:12:44 +0000 (00:12 +0200)
We call del_vqs twice when request_irq fails, this
makes no sense.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_pci_common.c

index d9a90582796710d7750942be21d1b6c41ac28a8d..423f3d9c154827b2310425c7dccc9d089b0fc1d0 100644 (file)
@@ -360,10 +360,8 @@ static int vp_try_to_find_vqs(struct virtio_device *vdev, unsigned nvqs,
                                  vring_interrupt, 0,
                                  vp_dev->msix_names[msix_vec],
                                  vqs[i]);
-               if (err) {
-                       vp_del_vq(vqs[i]);
+               if (err)
                        goto error_find;
-               }
        }
        return 0;