net: rds: changing the return type from int to void
authorSaurabh Sengar <saurabh.truth@gmail.com>
Fri, 30 Oct 2015 14:16:44 +0000 (19:46 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Nov 2015 20:35:19 +0000 (15:35 -0500)
as result of function rds_iw_flush_mr_pool is nowhere checked,
changing its return type from int to void.
also removing the unused variable rc as there is nothing to return

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/iw_rdma.c

index 6a8fbd6e69e7cf721c26aa742cc957e3be109fbd..d3d4454ffc84c6603397976e8c027b62c3300fbe 100644 (file)
@@ -75,7 +75,7 @@ struct rds_iw_mr_pool {
        int                     max_pages;
 };
 
-static int rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all);
+static void rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all);
 static void rds_iw_mr_pool_flush_worker(struct work_struct *work);
 static int rds_iw_init_fastreg(struct rds_iw_mr_pool *pool, struct rds_iw_mr *ibmr);
 static int rds_iw_map_fastreg(struct rds_iw_mr_pool *pool,
@@ -479,14 +479,13 @@ void rds_iw_sync_mr(void *trans_private, int direction)
  * If the number of MRs allocated exceeds the limit, we also try
  * to free as many MRs as needed to get back to this limit.
  */
-static int rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all)
+static void rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all)
 {
        struct rds_iw_mr *ibmr, *next;
        LIST_HEAD(unmap_list);
        LIST_HEAD(kill_list);
        unsigned long flags;
        unsigned int nfreed = 0, ncleaned = 0, unpinned = 0;
-       int ret = 0;
 
        rds_iw_stats_inc(s_iw_rdma_mr_pool_flush);
 
@@ -538,7 +537,6 @@ static int rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all)
        atomic_sub(nfreed, &pool->item_count);
 
        mutex_unlock(&pool->flush_lock);
-       return ret;
 }
 
 static void rds_iw_mr_pool_flush_worker(struct work_struct *work)