platform/x86: pmt: Fix a potential Oops on error in probe

The "ns->attr_grp" pointer can be NULL so this error handling code needs
to check for that to avoid an Oops.

Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20201117072251.GC1111239@mwanda
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/intel_pmt_class.c b/drivers/platform/x86/intel_pmt_class.c
index aa88dc23bbde668771d95860c2fe0db2a714985c..c8939fba45090788519b71afebd2a7b7d2a1d11b 100644 (file)
--- a/drivers/platform/x86/intel_pmt_class.c
+++ b/drivers/platform/x86/intel_pmt_class.c
@@ -225,7 +225,8 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry,
                return 0;
 
 fail_ioremap:
-       sysfs_remove_group(entry->kobj, ns->attr_grp);
+       if (ns->attr_grp)
+               sysfs_remove_group(entry->kobj, ns->attr_grp);
 fail_sysfs:
        device_unregister(dev);
 fail_dev_create: