projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6a79131
)
spi/sh-hspi: fix return value check in hspi_probe().
author
Cyril Roelandt
<tipecaml@gmail.com>
Wed, 12 Dec 2012 00:24:54 +0000
(
01:24
+0100)
committer
Grant Likely
<grant.likely@secretlab.ca>
Wed, 19 Dec 2012 15:11:41 +0000
(15:11 +0000)
According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/spi-sh-hspi.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/spi/spi-sh-hspi.c
b/drivers/spi/spi-sh-hspi.c
index 32f7b55fce093f07130bb7fd2af64f4d85609710..60cfae51c713818ef630f802db2e2e8c747f98d7 100644
(file)
--- a/
drivers/spi/spi-sh-hspi.c
+++ b/
drivers/spi/spi-sh-hspi.c
@@
-290,7
+290,7
@@
static int hspi_probe(struct platform_device *pdev)
}
clk = clk_get(NULL, "shyway_clk");
- if (
!clk
) {
+ if (
IS_ERR(clk)
) {
dev_err(&pdev->dev, "shyway_clk is required\n");
ret = -EINVAL;
goto error0;