drm/panthor: Fix a couple -ENOMEM error codes
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 2 Apr 2024 09:58:09 +0000 (12:58 +0300)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 3 Apr 2024 07:06:26 +0000 (09:06 +0200)
These error paths forgot to set the error code to -ENOMEM.

Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/cf5bbba5-427e-4940-b91e-925f9fa71f8d@moroto.mountain
drivers/gpu/drm/panthor/panthor_mmu.c

index fdd35249169fdbbb2568a65c29ca30d96f1b305b..a26b40aab26193d6327652b38c405b3bba8b714c 100644 (file)
@@ -1264,8 +1264,10 @@ static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx,
        op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
                                                 sizeof(*op_ctx->rsvd_page_tables.pages),
                                                 GFP_KERNEL);
-       if (!op_ctx->rsvd_page_tables.pages)
+       if (!op_ctx->rsvd_page_tables.pages) {
+               ret = -ENOMEM;
                goto err_cleanup;
+       }
 
        ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
                                    op_ctx->rsvd_page_tables.pages);
@@ -1318,8 +1320,10 @@ static int panthor_vm_prepare_unmap_op_ctx(struct panthor_vm_op_ctx *op_ctx,
                op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
                                                         sizeof(*op_ctx->rsvd_page_tables.pages),
                                                         GFP_KERNEL);
-               if (!op_ctx->rsvd_page_tables.pages)
+               if (!op_ctx->rsvd_page_tables.pages) {
+                       ret = -ENOMEM;
                        goto err_cleanup;
+               }
 
                ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
                                            op_ctx->rsvd_page_tables.pages);