ath10k: remove deprecated fw_crash_dump debugfs file
authorKalle Valo <kvalo@qca.qualcomm.com>
Fri, 22 Dec 2017 13:38:29 +0000 (15:38 +0200)
committerKalle Valo <kvalo@qca.qualcomm.com>
Wed, 27 Dec 2017 10:20:04 +0000 (12:20 +0200)
The fw_crash_dump file was deprecated by commmit 727000e6af34 ("ath10k: support
dev_coredump for crash dump") in v4.11 in favor of dev_coredump interface,
remove it now for good. Everyone should use dev_coredump now.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/debug.c

index 181fd8e2e61583cf0d788fb6c6f14c68eb7dffe1..358c34eeb2d2db2297c3208c6af59dc87393b045 100644 (file)
@@ -851,49 +851,6 @@ int ath10k_debug_fw_devcoredump(struct ath10k *ar)
        return 0;
 }
 
-static int ath10k_fw_crash_dump_open(struct inode *inode, struct file *file)
-{
-       struct ath10k *ar = inode->i_private;
-       struct ath10k_dump_file_data *dump;
-
-       ath10k_warn(ar, "fw_crash_dump debugfs file is deprecated, please use /sys/class/devcoredump instead.");
-
-       dump = ath10k_build_dump_file(ar, true);
-       if (!dump)
-               return -ENODATA;
-
-       file->private_data = dump;
-
-       return 0;
-}
-
-static ssize_t ath10k_fw_crash_dump_read(struct file *file,
-                                        char __user *user_buf,
-                                        size_t count, loff_t *ppos)
-{
-       struct ath10k_dump_file_data *dump_file = file->private_data;
-
-       return simple_read_from_buffer(user_buf, count, ppos,
-                                      dump_file,
-                                      le32_to_cpu(dump_file->len));
-}
-
-static int ath10k_fw_crash_dump_release(struct inode *inode,
-                                       struct file *file)
-{
-       vfree(file->private_data);
-
-       return 0;
-}
-
-static const struct file_operations fops_fw_crash_dump = {
-       .open = ath10k_fw_crash_dump_open,
-       .read = ath10k_fw_crash_dump_read,
-       .release = ath10k_fw_crash_dump_release,
-       .owner = THIS_MODULE,
-       .llseek = default_llseek,
-};
-
 static ssize_t ath10k_reg_addr_read(struct file *file,
                                    char __user *user_buf,
                                    size_t count, loff_t *ppos)
@@ -2460,9 +2417,6 @@ int ath10k_debug_register(struct ath10k *ar)
        debugfs_create_file("simulate_fw_crash", 0600, ar->debug.debugfs_phy, ar,
                            &fops_simulate_fw_crash);
 
-       debugfs_create_file("fw_crash_dump", 0400, ar->debug.debugfs_phy, ar,
-                           &fops_fw_crash_dump);
-
        debugfs_create_file("reg_addr", 0600, ar->debug.debugfs_phy, ar,
                            &fops_reg_addr);