staging: media: atmel: use for_each_endpoint_of_node()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 30 Jul 2024 00:35:21 +0000 (00:35 +0000)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 9 Aug 2024 05:56:39 +0000 (07:56 +0200)
We already have for_each_endpoint_of_node(), don't use
of_graph_get_next_endpoint() directly. Replace it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c

index 31b2b48085c59a67c56d09972d1606a8192ea47a..712f916f0935f5be7d4284cf2698828ef89a7e64 100644 (file)
@@ -333,20 +333,16 @@ static const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = {
 static int isc_parse_dt(struct device *dev, struct isc_device *isc)
 {
        struct device_node *np = dev->of_node;
-       struct device_node *epn = NULL;
+       struct device_node *epn;
        struct isc_subdev_entity *subdev_entity;
        unsigned int flags;
-       int ret;
+       int ret = -EINVAL;
 
        INIT_LIST_HEAD(&isc->subdev_entities);
 
-       while (1) {
+       for_each_endpoint_of_node(np, epn) {
                struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 };
 
-               epn = of_graph_get_next_endpoint(np, epn);
-               if (!epn)
-                       return 0;
-
                ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn),
                                                 &v4l2_epn);
                if (ret) {
index 020034f631f57c9ad136332d6d931002553199c6..9485167d5b7d7385431df579afaa879531680baa 100644 (file)
@@ -316,23 +316,19 @@ static const u32 isc_sama7g5_gamma_table[][GAMMA_ENTRIES] = {
 static int xisc_parse_dt(struct device *dev, struct isc_device *isc)
 {
        struct device_node *np = dev->of_node;
-       struct device_node *epn = NULL;
+       struct device_node *epn;
        struct isc_subdev_entity *subdev_entity;
        unsigned int flags;
-       int ret;
+       int ret = -EINVAL;
        bool mipi_mode;
 
        INIT_LIST_HEAD(&isc->subdev_entities);
 
        mipi_mode = of_property_read_bool(np, "microchip,mipi-mode");
 
-       while (1) {
+       for_each_endpoint_of_node(np, epn) {
                struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 };
 
-               epn = of_graph_get_next_endpoint(np, epn);
-               if (!epn)
-                       return 0;
-
                ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn),
                                                 &v4l2_epn);
                if (ret) {