staging/rtl8712: Remove all strcpy() uses in favor of strscpy()

strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. The safe replacement is strscpy().

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210717155145.15041-1-len.baker@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 2214aca0973088ee183224a1353d9755c1a8c1c7..9502f6aa53060dfe66014f823aa6fdce19e99c4d 100644 (file)
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -203,7 +203,7 @@ struct net_device *r8712_init_netdev(void)
        if (!pnetdev)
                return NULL;
        if (dev_alloc_name(pnetdev, ifname) < 0) {
-               strcpy(ifname, "wlan%d");
+               strscpy(ifname, "wlan%d", sizeof(ifname));
                dev_alloc_name(pnetdev, ifname);
        }
        padapter = netdev_priv(pnetdev);