media: cx231xx: Constify struct vb2_ops
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 16 Jun 2024 06:32:53 +0000 (08:32 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 21 Jun 2024 06:57:09 +0000 (08:57 +0200)
"struct vb2_ops" are not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
  36607    1156       0   37763    9383 drivers/media/usb/cx231xx/cx231xx-417.o

After:
=====
   text    data     bss     dec     hex filename
  36735    1016       0   37751    9377 drivers/media/usb/cx231xx/cx231xx-417.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/usb/cx231xx/cx231xx-417.c
drivers/media/usb/cx231xx/cx231xx-video.c

index 343a4433ed24ca608a22cdd763ffed6207e60bb4..abb967c8bd352cf2fee9bfd25638262560137ed4 100644 (file)
@@ -1453,7 +1453,7 @@ static void stop_streaming(struct vb2_queue *vq)
        return_all_buffers(dev, VB2_BUF_STATE_ERROR);
 }
 
-static struct vb2_ops cx231xx_video_qops = {
+static const struct vb2_ops cx231xx_video_qops = {
        .queue_setup            = queue_setup,
        .buf_queue              = buffer_queue,
        .start_streaming        = start_streaming,
index 8f347bbeeb32ea6a8173ff757245086a8f20eb8d..435eb0b32cb15c5104a5fc4d8ab82bb68ccfeb8c 100644 (file)
@@ -795,7 +795,7 @@ static void stop_streaming(struct vb2_queue *vq)
        return_all_buffers(dev, VB2_BUF_STATE_ERROR);
 }
 
-static struct vb2_ops cx231xx_video_qops = {
+static const struct vb2_ops cx231xx_video_qops = {
        .queue_setup            = queue_setup,
        .buf_queue              = buffer_queue,
        .start_streaming        = start_streaming,