drm/xe/sa: Drop redundant NULL assignments
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Fri, 20 Dec 2024 19:41:55 +0000 (20:41 +0100)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Sat, 18 Jan 2025 23:11:57 +0000 (00:11 +0100)
The sa_manager is drmm_kzalloc'ed so all members are already zero.
And in case of kvzalloc() failure we are not returning pointer to
the sa_manager at all, so no point in resetting .bo member.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241220194205.995-3-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_sa.c

index 4e7aba445ebc8a249d77f6be82053fca2ce85f5a..eb314ca7535591d6696be3ce7020d3fbfb11da5d 100644 (file)
@@ -44,8 +44,6 @@ struct xe_sa_manager *xe_sa_bo_manager_init(struct xe_tile *tile, u32 size, u32
        if (!sa_manager)
                return ERR_PTR(-ENOMEM);
 
-       sa_manager->bo = NULL;
-
        bo = xe_managed_bo_create_pin_map(xe, tile, size,
                                          XE_BO_FLAG_VRAM_IF_DGFX(tile) |
                                          XE_BO_FLAG_GGTT |
@@ -61,10 +59,8 @@ struct xe_sa_manager *xe_sa_bo_manager_init(struct xe_tile *tile, u32 size, u32
 
        if (bo->vmap.is_iomem) {
                sa_manager->cpu_ptr = kvzalloc(managed_size, GFP_KERNEL);
-               if (!sa_manager->cpu_ptr) {
-                       sa_manager->bo = NULL;
+               if (!sa_manager->cpu_ptr)
                        return ERR_PTR(-ENOMEM);
-               }
        } else {
                sa_manager->cpu_ptr = bo->vmap.vaddr;
                memset(sa_manager->cpu_ptr, 0, bo->ttm.base.size);