net: usb: ax88179_178a: avoid two consecutive device resets
authorJose Ignacio Tornos Martinez <jtornosm@redhat.com>
Mon, 20 Nov 2023 12:11:41 +0000 (13:11 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 21 Nov 2023 22:34:11 +0000 (14:34 -0800)
The device is always reset two consecutive times (ax88179_reset is called
twice), one from usbnet_probe during the device binding and the other from
usbnet_open.

Remove the non-necessary reset during the device binding and let the reset
operation from open to keep the normal behavior (tested with generic ASIX
Electronics Corp. AX88179 Gigabit Ethernet device).

Reported-by: Herb Wei <weihao.bj@ieisystem.com>
Tested-by: Herb Wei <weihao.bj@ieisystem.com>
Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Link: https://lore.kernel.org/r/20231120121239.54504-1-jtornosm@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/ax88179_178a.c

index aff39bf3161ded7e5a67289c6cbdac0eacbf0ef0..fb0903ad6de38c6a79683dacce288038dc8ea283 100644 (file)
@@ -1298,8 +1298,6 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
 
        netif_set_tso_max_size(dev->net, 16384);
 
-       ax88179_reset(dev);
-
        return 0;
 }