cpufreq: sun50i: Fix build warning around snprint()
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 22 Apr 2024 03:28:51 +0000 (08:58 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 23 Apr 2024 06:13:22 +0000 (11:43 +0530)
The Sun50i driver generates a warning with W=1:

warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]

Fix it by allocating a big enough array to print an integer.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404191715.LDwMm2gP-lkp@intel.com/
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
drivers/cpufreq/sun50i-cpufreq-nvmem.c

index 30e5c337611ce6f0991ccfebe3f67a958af58c6f..cd50cea16a87e68b2d093129ce068757d16f7f7f 100644 (file)
@@ -19,8 +19,6 @@
 #include <linux/pm_opp.h>
 #include <linux/slab.h>
 
-#define MAX_NAME_LEN   7
-
 #define NVMEM_MASK     0x7
 #define NVMEM_SHIFT    5
 
@@ -208,7 +206,7 @@ static int sun50i_cpufreq_get_efuse(void)
 static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
 {
        int *opp_tokens;
-       char name[MAX_NAME_LEN];
+       char name[] = "speedXXXXXXXXXXX"; /* Integers can take 11 chars max */
        unsigned int cpu, supported_hw;
        struct dev_pm_opp_config config = {};
        int speed;
@@ -235,7 +233,7 @@ static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
                config.supported_hw_count = 1;
        }
 
-       snprintf(name, MAX_NAME_LEN, "speed%d", speed);
+       snprintf(name, sizeof(name), "speed%d", speed);
        config.prop_name = name;
 
        for_each_possible_cpu(cpu) {