qed*: Fix pause setting
authorYuval Mintz <Yuval.Mintz@qlogic.com>
Fri, 19 Aug 2016 05:34:57 +0000 (08:34 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Aug 2016 06:04:40 +0000 (23:04 -0700)
When moving into using ethtool's link_ksetting, qed started
supplying its own bitmask of speed/capabilities, but qede
is still checking for the SUPPORTED value to determine whether
it supports pause.

Fixes: 054c67d1c82a ("qed*: Add support for ethtool link_ksettings callbacks")
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_ethtool.c
include/linux/qed/qed_if.h

index 6e17ee10e748e2ac1c425287e2738e698d962e55..51782bf4987f5ae9ca8bc98e93c15f6a937e8bd5 100644 (file)
@@ -672,7 +672,7 @@ static int qede_set_pauseparam(struct net_device *dev,
        memset(&params, 0, sizeof(params));
        params.override_flags |= QED_LINK_OVERRIDE_PAUSE_CONFIG;
        if (epause->autoneg) {
-               if (!(current_link.supported_caps & SUPPORTED_Autoneg)) {
+               if (!(current_link.supported_caps & QED_LM_Autoneg_BIT)) {
                        DP_INFO(edev, "autoneg not supported\n");
                        return -EINVAL;
                }
index 3ed7d20e3811afe2b42525c4f63e59bc7ff8ab06..d8dc5c2243d5e018b731e1f9fac9b7e32432015f 100644 (file)
@@ -318,9 +318,11 @@ struct qed_link_params {
 struct qed_link_output {
        bool    link_up;
 
-       u32     supported_caps;         /* In SUPPORTED defs */
-       u32     advertised_caps;        /* In ADVERTISED defs */
-       u32     lp_caps;                /* In ADVERTISED defs */
+       /* In QED_LM_* defs */
+       u32     supported_caps;
+       u32     advertised_caps;
+       u32     lp_caps;
+
        u32     speed;                  /* In Mb/s */
        u8      duplex;                 /* In DUPLEX defs */
        u8      port;                   /* In PORT defs */