staging: gpib: Using struct gpib_sad_ioctl

Using Linux code style for 'struct gpib_sad_ioctl' to remove typedef.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-15-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index 19bda8ff095d483799302f4de9bce4a19f4c06af..ceaf9cc93233ab4c1450a903e10a6760882d6fae 100644 (file)
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -1474,7 +1474,7 @@ static int pad_ioctl(struct gpib_board *board, struct gpib_file_private *file_pr
 static int sad_ioctl(struct gpib_board *board, struct gpib_file_private *file_priv,
                     unsigned long arg)
 {
-       sad_ioctl_t cmd;
+       struct gpib_sad_ioctl cmd;
        int retval;
        struct gpib_descriptor *desc;
 

diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/uapi/gpib_ioctl.h
index 7cb09cac6cd0cc0a856b0040c6aea8ed429912ba..a0fbc660ab996e8fd0555128d4152fa0fe8607ae 100644 (file)
--- a/drivers/staging/gpib/uapi/gpib_ioctl.h
+++ b/drivers/staging/gpib/uapi/gpib_ioctl.h
@@ -97,10 +97,10 @@ struct gpib_pad_ioctl {
        unsigned int pad;
 };
 
-typedef struct {
+struct gpib_sad_ioctl {
        unsigned int handle;
        int sad;
-} sad_ioctl_t;
+};
 
 // select a piece of hardware to attach by its sysfs device path
 typedef struct {
@@ -135,7 +135,7 @@ enum gpib_ioctl {
        IBCAC = _IOW(GPIB_CODE, 12, int),
        IBLINES = _IOR(GPIB_CODE, 14, short),
        IBPAD = _IOW(GPIB_CODE, 15, struct gpib_pad_ioctl),
-       IBSAD = _IOW(GPIB_CODE, 16, sad_ioctl_t),
+       IBSAD = _IOW(GPIB_CODE, 16, struct gpib_sad_ioctl),
        IBTMO = _IOW(GPIB_CODE, 17, unsigned int),
        IBRSP = _IOWR(GPIB_CODE, 18, struct gpib_serial_poll_ioctl),
        IBEOS = _IOW(GPIB_CODE, 19, struct gpib_eos_ioctl),