workqueue: Remove the arguments @hotplug_cpu and @online from wq_update_pod()
authorLai Jiangshan <jiangshan.ljs@antgroup.com>
Thu, 11 Jul 2024 08:35:46 +0000 (16:35 +0800)
committerTejun Heo <tj@kernel.org>
Thu, 11 Jul 2024 22:50:35 +0000 (12:50 -1000)
The arguments @hotplug_cpu and @online are not used in wq_update_pod()
since the functions called by wq_update_pod() don't need them.

Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c

index 42190bdeacbdbff65cabdd1541aae45baf1950f4..d9e0006c0be700b3bed579064979f01f130e0e64 100644 (file)
@@ -5344,8 +5344,6 @@ int apply_workqueue_attrs(struct workqueue_struct *wq,
  * wq_update_pod - update pod affinity of a wq for CPU hot[un]plug
  * @wq: the target workqueue
  * @cpu: the CPU to update pool association for
- * @hotplug_cpu: the CPU coming up or going down
- * @online: whether @cpu is coming up or going down
  *
  * This function is to be called from %CPU_DOWN_PREPARE, %CPU_ONLINE and
  * %CPU_DOWN_FAILED.  @cpu is being hot[un]plugged, update pod affinity of
@@ -5362,8 +5360,7 @@ int apply_workqueue_attrs(struct workqueue_struct *wq,
  * CPU_DOWN. If a workqueue user wants strict affinity, it's the user's
  * responsibility to flush the work item from CPU_DOWN_PREPARE.
  */
-static void wq_update_pod(struct workqueue_struct *wq, int cpu,
-                         int hotplug_cpu, bool online)
+static void wq_update_pod(struct workqueue_struct *wq, int cpu)
 {
        struct pool_workqueue *old_pwq = NULL, *pwq;
        struct workqueue_attrs *target_attrs;
@@ -6584,7 +6581,7 @@ int workqueue_online_cpu(unsigned int cpu)
                        int tcpu;
 
                        for_each_cpu(tcpu, pt->pod_cpus[pt->cpu_pod[cpu]])
-                               wq_update_pod(wq, tcpu, cpu, true);
+                               wq_update_pod(wq, tcpu);
 
                        mutex_lock(&wq->mutex);
                        wq_update_node_max_active(wq, -1);
@@ -6619,7 +6616,7 @@ int workqueue_offline_cpu(unsigned int cpu)
                        int tcpu;
 
                        for_each_cpu(tcpu, pt->pod_cpus[pt->cpu_pod[cpu]])
-                               wq_update_pod(wq, tcpu, cpu, false);
+                               wq_update_pod(wq, tcpu);
 
                        mutex_lock(&wq->mutex);
                        wq_update_node_max_active(wq, cpu);
@@ -6908,7 +6905,7 @@ static int wq_affn_dfl_set(const char *val, const struct kernel_param *kp)
 
        list_for_each_entry(wq, &workqueues, list) {
                for_each_online_cpu(cpu) {
-                       wq_update_pod(wq, cpu, cpu, true);
+                       wq_update_pod(wq, cpu);
                }
        }
 
@@ -7927,7 +7924,7 @@ void __init workqueue_init_topology(void)
         */
        list_for_each_entry(wq, &workqueues, list) {
                for_each_online_cpu(cpu)
-                       wq_update_pod(wq, cpu, cpu, true);
+                       wq_update_pod(wq, cpu);
                if (wq->flags & WQ_UNBOUND) {
                        mutex_lock(&wq->mutex);
                        wq_update_node_max_active(wq, -1);