block: remove the backing_inode variable in bdev_statx
authorChristoph Hellwig <hch@lst.de>
Wed, 23 Apr 2025 05:37:40 +0000 (07:37 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 24 Apr 2025 13:35:09 +0000 (07:35 -0600)
backing_inode is only used once, so remove it and update the comment
describing the bdev lookup to be a bit more clear.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20250423053810.1683309-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bdev.c

index e29b3b6d1707b8b7c8fe840f4e94623f539752d2..b57c2c0853fc89eddfa2af405635fc8ae13dd8d4 100644 (file)
@@ -1313,18 +1313,15 @@ void sync_bdevs(bool wait)
 void bdev_statx(struct path *path, struct kstat *stat,
                u32 request_mask)
 {
-       struct inode *backing_inode;
        struct block_device *bdev;
 
-       backing_inode = d_backing_inode(path->dentry);
-
        /*
-        * Note that backing_inode is the inode of a block device node file,
-        * not the block device's internal inode.  Therefore it is *not* valid
-        * to use I_BDEV() here; the block device has to be looked up by i_rdev
+        * Note that d_backing_inode() returns the block device node inode, not
+        * the block device's internal inode.  Therefore it is *not* valid to
+        * use I_BDEV() here; the block device has to be looked up by i_rdev
         * instead.
         */
-       bdev = blkdev_get_no_open(backing_inode->i_rdev);
+       bdev = blkdev_get_no_open(d_backing_inode(path->dentry)->i_rdev);
        if (!bdev)
                return;