drivers/crypto/qat: use seq_hex_dump() to dump buffers
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 9 Sep 2015 22:38:36 +0000 (15:38 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 10 Sep 2015 20:29:01 +0000 (13:29 -0700)
Instead of custom approach let's use recently introduced seq_hex_dump()
helper.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Joe Perches <joe@perches.com>
Cc: Helge Deller <deller@gmx.de>
Cc: Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/crypto/qat/qat_common/adf_transport_debug.c

index e41986967294164f0e226f39faff1e817fb3c590..52340b9bb3873bbf1a327c7b41bbe3f2ffa5b222 100644 (file)
@@ -86,9 +86,7 @@ static int adf_ring_show(struct seq_file *sfile, void *v)
 {
        struct adf_etr_ring_data *ring = sfile->private;
        struct adf_etr_bank_data *bank = ring->bank;
-       uint32_t *msg = v;
        void __iomem *csr = ring->bank->csr_addr;
-       int i, x;
 
        if (v == SEQ_START_TOKEN) {
                int head, tail, empty;
@@ -113,18 +111,8 @@ static int adf_ring_show(struct seq_file *sfile, void *v)
                seq_puts(sfile, "----------- Ring data ------------\n");
                return 0;
        }
-       seq_printf(sfile, "%p:", msg);
-       x = 0;
-       i = 0;
-       for (; i < (ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2); i++) {
-               seq_printf(sfile, " %08X", *(msg + i));
-               if ((ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2) != i + 1 &&
-                   (++x == 8)) {
-                       seq_printf(sfile, "\n%p:", msg + i + 1);
-                       x = 0;
-               }
-       }
-       seq_puts(sfile, "\n");
+       seq_hex_dump(sfile, "", DUMP_PREFIX_ADDRESS, 32, 4,
+                    v, ADF_MSG_SIZE_TO_BYTES(ring->msg_size), false);
        return 0;
 }